Add a general notion of experimental features to sourcekit-lsp #1389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Background indexing probably won’t be the last experimental feature in sourcekit-lsp that we want to gate behind a feature flag. Instead of adding new parameters ad-hoc, introduce a general notion of experimental features.
|
@swift-ci Please test |
bnbarham
approved these changes
Jun 1, 2024
|
@ahoppen I am pretty sure this broke the linux PR build: https://ci.swift.org/job/oss-swift-pr-test-ubuntu-20_04/ |
hamishknight
reviewed
Jun 3, 2024
Comment on lines
+52
to
+53
| /// Experimental features that are enabled. | ||
| public var experimentalFeatures: [ExperimentalFeature] |
There was a problem hiding this comment.
Any reason not to make a Set?
There was a problem hiding this comment.
My assumption was that you usually pass less than 3 experimental features (honestly, most likely you pass 0) and I think a linear scan through an array is quicker than a set lookup in that case.
There was a problem hiding this comment.
Yeah I wasn't really thinking of performance, more just semantically it feels like Set better fits. But I don't feel strongly at all 🤷
There was a problem hiding this comment.
Neither do I. It’s in as an array now, let’s just leave it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background indexing probably won’t be the last experimental feature in sourcekit-lsp that we want to gate behind a feature flag. Instead of adding new parameters ad-hoc, introduce a general notion of experimental features.