Show deinit in document symbols
#1397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://128715297
|
@swift-ci Please test |
bnbarham
approved these changes
Jun 2, 2024
bnbarham
reviewed
Jun 2, 2024
| return record( | ||
| node: node, | ||
| name: node.deinitKeyword.text, | ||
| symbolKind: .null, |
There was a problem hiding this comment.
Kind of weird, but could make constructor?
There was a problem hiding this comment.
I thought about it as well but then felt that constructor is weird because it’s not a constructor… But I don’t have strong opinions here.
There was a problem hiding this comment.
IMO it would be more like a function (assuming that doesn't break any invariants), but also don't feel strongly 🤷
There was a problem hiding this comment.
I just checked and VS Code at least uses the same icon for constructor and function, so it’s odd if deinit uses a different icon. clangd uses constructor, so let’s just do that as well.
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://128715297