Skip to content

Add an extension to the LogMessageNotification to add a message to a specific log in the client #1398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jun 2, 2024

If the editor has support for this LSP extension, it can create a separate output view for the index log.

For example, in VS Code, we could have one output view for the standard LSP logging (which are the messages between VS Code and SourceKit-LSP if verbose logging is enabled in VS Code) and a separate log that shows information about background indexing.

rdar://128572032

…specific log in the client

If the editor has support for this LSP extension, it can create a separate output view for the index log.

For example, in VS Code, we could have one output view for the standard LSP logging (which are the messages between VS Code and SourceKit-LSP if verbose logging is enabled in VS Code) and a separate log that shows information about background indexing.

rdar://128572032
@ahoppen ahoppen requested review from bnbarham and hamishknight June 2, 2024 00:14
@ahoppen ahoppen requested a review from benlangmuir as a code owner June 2, 2024 00:14
@ahoppen
Copy link
Member Author

ahoppen commented Jun 2, 2024

@swift-ci Please test

@ahoppen ahoppen merged commit 175e85e into swiftlang:main Jun 2, 2024
3 checks passed
@ahoppen ahoppen deleted the separate-index-log-in-client branch June 2, 2024 05:32
Copy link
Contributor

@hamishknight hamishknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants