Skip to content

Move debug subcommands of sourcekit-lsp to a debug subcommand and unhide them #1399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jun 2, 2024

We have a few subcommands on sourcekit-lsp that are intended for debugging sourcekit-lsp and that are thus hidden. This moves them all to a debug subcommand (eg. sourcekit-lsp debug run-sourcekitd-request) and unhides them. That makes them more discoverable for interested users and also helps developers of sourcekit-lsp remember what they are called.

rdar://128443298

…nhide them

We have a few subcommands on sourcekit-lsp that are intended for debugging sourcekit-lsp and that are thus hidden. This moves them all to a `debug` subcommand (eg. `sourcekit-lsp debug run-sourcekitd-request`) and unhides them. That makes them more discoverable for interested users and also helps developers of sourcekit-lsp remember what they are called.

rdar://128443298
@ahoppen ahoppen requested review from bnbarham and hamishknight June 2, 2024 00:27
@ahoppen ahoppen requested a review from benlangmuir as a code owner June 2, 2024 00:27
@ahoppen
Copy link
Member Author

ahoppen commented Jun 2, 2024

@swift-ci Please test

@ahoppen ahoppen merged commit 0e0594b into swiftlang:main Jun 2, 2024
3 checks passed
@ahoppen ahoppen deleted the debug-subcommand branch June 2, 2024 05:32
Copy link
Contributor

@hamishknight hamishknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants