Show “Preparing targets” as index status if we only have preparation tasks and no index tasks #1400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tasks and no index tasks I was wondering for a while why we were showing “Indexing 0 / 0” as the index progress. I think it’s if we only have a preparation task but no index tasks running. I’m not entirely sure how this happens because preparation should only happen for two reasons: - We are preparing a target so we can index a files -> We should have an active index task - We are preparing a file for editor functionality of the current file -> we should have a `inProgressPrepareForEditorTask` Maybe I’ll understand it once we have this change in. It seems like a worthwhile change in any way.
|
@swift-ci Please test |
bnbarham
approved these changes
Jun 2, 2024
ahoppen
added a commit
that referenced
this pull request
Jun 3, 2024
…gress Remove `showActivePreparationTasksInProgress` experimental feature 🚥 #1400
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wondering for a while why we were showing “Indexing 0 / 0” as the index progress. I think it’s if we only have a preparation task but no index tasks running. I’m not entirely sure how this happens because preparation should only happen for two reasons:
inProgressPrepareForEditorTaskMaybe I’ll understand it once we have this change in. It seems like a worthwhile change in any way.