Skip testJumpToSatisfiedProtocolRequirementInExtension if the toolchain does not mark overridable function declarations as dynamic
#1480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hain does not mark overridable function declarations as dynamic This test requires swiftlang/swift#74080 and should be skipped if the host toolchain does not have that change.
|
@swift-ci Please test |
bnbarham
approved these changes
Jun 17, 2024
| @@ -233,6 +233,37 @@ public actor SkipUnless { | |||
| } | |||
| } | |||
|
|
|||
| /// Checks if the toolchain contains https://github.com/apple/swift/pull/74080. | |||
There was a problem hiding this comment.
I'm not really sure what to do about this, but the skip test is really the test itself 😅
There was a problem hiding this comment.
Yes, I know. The key point here is that it won’t skip the test if the toolchain is ≥6.1 or if we are on Swift CI (SWIFTCI_USE_LOCAL_DEPS is set – https://github.com/apple/sourcekit-lsp/blob/main/Documentation/Environment%20Variables.md#build-time)
There was a problem hiding this comment.
Well, my point was more that it would skip if the original test would fail, though depends on the failure (ie. if more results are returned then it wouldn't skip, but if the result is missing at all then it will). Anyway, I think it's fine 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test requires swiftlang/swift#74080 and should be skipped if the host toolchain does not have that change.
Fixes a test failure when running SourceKit-LSP tests using Xcode 15.4.