Add a test case that we get build settings for a SwiftPM package if package hasn't been resolved #1618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ackage hasn't been resolved
|
swiftlang/swift-package-manager#7865 |
ahoppen
pushed a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Aug 8, 2024
### Motivation: We need to use a separate inner scope to capture any problems during build plan construction and make a decision to stop based on that. The current logic checks the scope that is passed in which tracks errors emitted elsewhere. ### Modifications: - Passes an child scope called "Planning" to the `computeDestinations` functions that is used to construct the plan. ### Result: sourcekit-lsp no longer fails if there is no Package.resolved - swiftlang/sourcekit-lsp#1618
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a package had a package dependency but we haven’t resolved packages, we should still be able to get build settings for the existing files – just without the dependencies. This behavior broken by swiftlang/swift-package-manager#7854 and is being fixed by swiftlang/swift-package-manager#7865.