Don’t block the generation of a build system by build graph generation #1632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
hamishknight
approved these changes
Aug 19, 2024
|
|
||
| /// Check that the entries in `uriToWorkspace` are still up-to-date after workspaces might have changed. | ||
| /// | ||
| /// For any entries that are not up-to-date, close the document in the old workspace and open it in the new document. |
There was a problem hiding this comment.
Suggested change
| /// For any entries that are not up-to-date, close the document in the old workspace and open it in the new document. | |
| /// For any entries that are not up-to-date, close the document in the old workspace and open it in the new workspace. |
| package func generateBuildGraph(allowFileSystemWrites: Bool) async throws { | ||
| try await self.reloadPackage(forceResolvedVersions: !isForIndexBuild || !allowFileSystemWrites) | ||
| package func generateBuildGraph() async throws { | ||
| try await self.reloadPackage(forceResolvedVersions: !isForIndexBuild) |
There was a problem hiding this comment.
forceResolvedVersions is now always !isForIndexBuild, is it worth keeping it as a parameter?
There was a problem hiding this comment.
Nice catch, I didn’t notice we can remove it even one level further. 👍🏽
ahoppen
force-pushed
the
lazy-workspace-loading
branch
2 times, most recently
from
c8454f5 to
0151a0f
Compare
|
@swift-ci Please test |
We currently load the entire package before generating a `SwiftPMBuildSystem`. That means that the initialize request to SourceKit-LSP is blocked until the package has been loaded, preventing us from offering any sort of functionality, including syntactic functionality like formatting. Decouple build system creation and build graph generation (aka. package loading for SwiftPM). We can operate with fallback build settings until the build graph has been loaded and reopen the document once the proper build settings are available. rdar://126644596
ahoppen
force-pushed
the
lazy-workspace-loading
branch
from
0151a0f to
6e0281f
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently load the entire package before generating a
SwiftPMBuildSystem. That means that the initialize request to SourceKit-LSP is blocked until the package has been loaded, preventing us from offering any sort of functionality, including syntactic functionality like formatting.Decouple build system creation and build graph generation (aka. package loading for SwiftPM). We can operate with fallback build settings until the build graph has been loaded and reopen the document once the proper build settings are available.
rdar://126644596