Remove custom decoding function from SourceKitLSPOptions
#1646
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We forgot to decode the following keys in the custom decode function, which meant that you couldn’t set them using SourceKit-LSP’s
config.json
file.backgroundPreparationMode
sourcekitdRequestTimeout
cancelTextDocumentRequestsOnEditAndClose
We had the custom decoder function so that the keys weren’t required in the JSON but we could access eg.
SwiftPMOptions
without needing to deal with optionals in the codebase.Make the accesses to these nested options structs a little more verbose but eliminate the source of the above bug, which seems like a good tradeoff.