Skip to content

Make Workspace the delegate of a BuildSystemManager #1656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Sep 10, 2024

Workspace is responsible for creating the BuildSystemManager and responds to most of the delegate calls. It should thus also be the delegate of BuildSystemManager.

@ahoppen
Copy link
Member Author

ahoppen commented Sep 10, 2024

@swift-ci Please test

`Workspace` is responsible for creating the `BuildSystemManager` and responds to most of the delegate calls. It should thus also be the delegate of `BuildSystemManager`.
@ahoppen
Copy link
Member Author

ahoppen commented Sep 10, 2024

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Sep 10, 2024

@swift-ci Please test Windows

@ahoppen ahoppen merged commit 37f7540 into swiftlang:main Sep 11, 2024
3 checks passed
@ahoppen ahoppen deleted the workspace-delegate branch September 11, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant