Skip to content

Migrate fileHandlingCapability and prepare to BSP and remove registerForChangeNotifications #1659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Sep 11, 2024

Three somewhat unrelated commits:

  • Instead of having FileHandlingCapability for a source file, check if it belongs to any targets
  • Remove registerForChangeNotifications
    • This was only really used for the legacy BSP integration, which we are phasing out in favor of the new SourceKitOptions request.
  • Migrate BuildSystem.prepare to a BSP request

This was only really used for the legacy BSP integration, which we are phasing out in favor of the new `SourceKitOptions` request.
@ahoppen
Copy link
Member Author

ahoppen commented Sep 11, 2024

@swift-ci Please test

@ahoppen ahoppen merged commit cf47f2c into swiftlang:main Sep 11, 2024
3 checks passed
@ahoppen ahoppen deleted the more-bsp branch September 11, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant