Use a LocalConnection to communicate the BSP messages between SourceKit-LSP and the build system
#1668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
connection-based-bsp
branch
from
c0660cd to
77102ae
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
connection-based-bsp
branch
from
77102ae to
5abac15
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
connection-based-bsp
branch
from
5abac15 to
52a2a19
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
connection-based-bsp
branch
from
52a2a19 to
767eebf
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
connection-based-bsp
branch
from
767eebf to
8372961
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
…nd `BuildSystem`
…`BuildSystemManager`
ahoppen
force-pushed
the
connection-based-bsp
branch
from
8372961 to
c93f193
Compare
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
|
@swift-ci Please test macOS |
|
@swift-ci Please test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This concludes the majority of the internal refactoring to BSP because the build system and SourceKit-LSP now communicate asynchronously using BSP requests. The next steps are:
FIXMEcommentsBuildServerBuildSystemand instead let theBuildSystemManagerspeak directly to a build server, no longer going throughBuiltInBuildSystemand thus opening all the new functionality for external build serversBuildSystemIntegrationmodule to make sure that things are named consistently, we don’t have unused methods left over.