Adopt faster traverseModules implementation in SwiftPM
#1683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
changed the title
traverseModules implementation in SwiftPMtraverseModules implementation in SwiftPM 🚥 #1682
hamishknight
approved these changes
Sep 19, 2024
ahoppen
force-pushed
the
traverse-modules
branch
from
ff2e4fc to
2d55388
Compare
We no longer need `depth`. Adopt a faster version of `traverseModules` that doesn’t return the depth. rdar://136107035
ahoppen
force-pushed
the
traverse-modules
branch
from
2d55388 to
40cc4c6
Compare
ahoppen
changed the title
traverseModules implementation in SwiftPM 🚥 #1682traverseModules implementation in SwiftPM
|
swiftlang/swift-package-manager#7977 @swift-ci Please test |
ahoppen
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Sep 20, 2024
…7977) Companion of swiftlang/sourcekit-lsp#1683 --- Opening the SourceKit-LSP workspace using a debug build of sourcekit-lsp takes about 35s because `traverseModules` generates about 800,000 callback calls. All SourceKit-LSP needs now are the modules and their dependencies, so we can refactor `traverseModules` to just return that information avoid visiting the same modules multiple times. With theses changes getting all modules and their dependencies only takes ~0.013s. rdar://136107035
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion of swiftlang/swift-package-manager#7977
Adjustments because
traverseModulesno longer returns depthWe no longer need
depth. Adopt a faster version oftraverseModulesthat doesn’t return the depth.rdar://136107035