Use fallback build settings if build system doesn’t provide build settings within a timeout #1700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
ahoppen
force-pushed
the
build-settings-timeout
branch
from
72e073a to
558ef62
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
build-settings-timeout
branch
from
558ef62 to
415bba0
Compare
ahoppen
changed the title
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
hamishknight
approved these changes
Sep 26, 2024
| body: @escaping @Sendable () async throws -> T?, | ||
| resultReceivedAfterTimeout: @escaping @Sendable () async -> Void | ||
| ) async throws -> T? { | ||
| let didHitTimeout = AtomicBool(initialValue: false) |
There was a problem hiding this comment.
Nothing seems to set this to true
There was a problem hiding this comment.
Oh, thanks for catching that!
…tings within a timeout When we receive build settings after hitting the timeout, we call `fileBuildSettingsChanged` on the delegate, which should cause the document to get re-opened in sourcekitd and diagnostics to get refreshed. rdar://136332685
ahoppen
force-pushed
the
build-settings-timeout
branch
from
415bba0 to
78217ec
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we receive build settings after hitting the timeout, we call
fileBuildSettingsChangedon the delegate, which should cause the document to get re-opened in sourcekitd and diagnostics to get refreshed.rdar://136332685