When withTimeout hits a timeout, don’t wait for cooperative cancellation before returning
#1730
Conversation
|
@swift-ci Please test |
|
@swift-ci Please test Linux |
|
Heh, you might want to consider renaming this to withUnstructuredTimeout or something like that. Giving up structured concurrency should be explicit I think as you lost priority escalation here. |
…ation before returning Previously, when we hit the timeout in `withTimeout`, we just cancelled `body` but relied on cooperative cancellation before the caller could continue. Since the caller is obviously no longer interested in the operation, we can return with `CancellationError` immediately. Fixes swiftlang#883 rdar://116705684
ahoppen
force-pushed
the
finish-immediately-timeout
branch
from
50d527d to
86653b3
Compare
|
Good catch, @ktoso. I implemented priority propagation now. |
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
|
That does the trick with the hot loop around task.priority... tbh I'd rather just admit this drops structured concurrency, but if you've happy with this then your call. We should provide a built-in operation for this soon, the while-true loop is very wasteful 😭 |
|
I would be very happy to see native implementations of all the async utilities I have in here. But until then, I’ve got to implement them in the best way I can… |
Previously, when we hit the timeout in
withTimeout, we just cancelledbodybut relied on cooperative cancellation before the caller could continue. Since the caller is obviously no longer interested in the operation, we can return withCancellationErrorimmediately.Fixes #883
rdar://116705684