Skip to content

Batch updates to the syntactic test index on fileDidChange events #1869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Batch updates to the syntactic test index on fileDidChange events #1869

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Sources/SourceKitLSP/Swift/SyntacticTestIndex.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,20 +129,24 @@ actor SyntacticTestIndex {
}

func filesDidChange(_ events: [FileEvent]) {
var removedFiles: Set<DocumentURI> = []
var filesToRescan: [DocumentURI] = []
for fileEvent in events {
switch fileEvent.type {
case .created:
// We don't know if this is a potential test file. It would need to be added to the index via
// `listOfTestFilesDidChange`
break
case .changed:
rescanFiles([fileEvent.uri])
filesToRescan.append(fileEvent.uri)
case .deleted:
removeFilesFromIndex([fileEvent.uri])
removedFiles.insert(fileEvent.uri)
default:
logger.error("Ignoring unknown FileEvent type \(fileEvent.type.rawValue) in SyntacticTestIndex")
}
}
removeFilesFromIndex(removedFiles)
rescanFiles(filesToRescan)
}

/// Called when a list of files was updated. Re-scans those files
Expand Down