Skip to content

Fix test failures when running SourceKit-LSP tests with an Xcode toolchain #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jan 16, 2025

We need to jump through a few extra hoops when the SourceKit plugin is located in SourceKit-LSP’s build folder and we are using sourcekitd_plugin_initialize instead of sourcekitd_plugin_initialize_2.

@ahoppen ahoppen requested review from rintaro and bnbarham January 16, 2025 17:42
@ahoppen
Copy link
Member Author

ahoppen commented Jan 16, 2025

@swift-ci Please test

…chain

We need to jump through a few extra hoops when the SourceKit plugin is located in SourceKit-LSP’s build folder and we are using `sourcekitd_plugin_initialize` instead of `sourcekitd_plugin_initialize_2`.
@ahoppen ahoppen force-pushed the plugin-tests-using-xcode-toolchain branch from 95bd04b to 99019bb Compare January 16, 2025 20:44
@ahoppen
Copy link
Member Author

ahoppen commented Jan 16, 2025

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Jan 16, 2025

@swift-ci Please test Windows

@ahoppen ahoppen merged commit 76954e0 into swiftlang:main Jan 17, 2025
3 checks passed
@ahoppen ahoppen deleted the plugin-tests-using-xcode-toolchain branch January 17, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant