Skip to content

Gardening #1950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 25, 2025
Merged

Gardening #1950

merged 2 commits into from
Jan 25, 2025

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jan 22, 2025

  • Fix build warnings, quite a few of these were reminders to clean things up once we no longer need to support testing using compilers and sourcekitd from older toolchains
  • Remove SkipUnless checks that always evaluate to true, because we don’t support testing SourceKit-LSP using toolchains that don’t contain these features anymore

@ahoppen ahoppen requested a review from bnbarham January 22, 2025 22:08
@ahoppen
Copy link
Member Author

ahoppen commented Jan 22, 2025

@swift-ci Please test

Quite a few of these were reminders to clean things up once we no longer need to support testing using compilers and sourcekitd from older toolchains.
We don’t support testing SourceKit-LSP using toolchains that don’t contain these features anymore.
@ahoppen
Copy link
Member Author

ahoppen commented Jan 24, 2025

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Jan 24, 2025

@swift-ci Please test Windows

1 similar comment
@ahoppen
Copy link
Member Author

ahoppen commented Jan 24, 2025

@swift-ci Please test Windows

@ahoppen ahoppen merged commit c67c06e into swiftlang:main Jan 25, 2025
3 checks passed
@ahoppen ahoppen deleted the gardening branch January 25, 2025 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants