If a build server doesn’t specify -index-store-path in the SourceKit options, add it during background indexing
#2000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should always infer these from the build system and I can’t think of a reason to override these settings.
|
@swift-ci Please test |
bnbarham
reviewed
Feb 25, 2025
| struct NoIndexStorePathError: Error {} | ||
| throw NoIndexStorePathError() | ||
| } | ||
| if let indexStorePath = args.firstIndex(of: "-index-store-path"), indexStorePath + 1 < args.count { |
There was a problem hiding this comment.
lastIndex in case there's multiple? lastIndexStorePathArgument could also use lastIndex rather than the reverse loop it has now.
ahoppen
force-pushed
the
index-store-path-option
branch
from
8cbb868 to
4b6b243
Compare
|
@swift-ci Please test |
bnbarham
approved these changes
Feb 26, 2025
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
index-store-path-option
branch
from
4b6b243 to
a3086d7
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
…t options, add it during background indexing
ahoppen
force-pushed
the
index-store-path-option
branch
from
a3086d7 to
628ce3c
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, remove options to override the index store path and index database path. We should always infer these from the build system and I can’t think of a reason to override these settings.