Don’t poll the index for unit changes on every filesDidChange call
#2003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pollForUnitChangesAndWait` is a costly operation since it iterates through all the unit files on the file system. We should only run it during initial indexing (where we might need to build the initial indexstore-db) but not for any subsequent indexing calls.
|
@swift-ci Please test |
bnbarham
approved these changes
Feb 26, 2025
| // potentially not knowing about unit files, which causes the corresponding source files to be re-indexed. | ||
| index.pollForUnitChangesAndWait() | ||
| if ensureAllUnitsRegisteredInIndex { | ||
| index.pollForUnitChangesAndWait() |
There was a problem hiding this comment.
Should we add some additional documentation to pollForUnitChangesAndWait to describe what it actually does (and the fact it's costly) rather than just "for testing"?
There was a problem hiding this comment.
Yeah, I’ll add some to indexstore-db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pollForUnitChangesAndWaitis a costly operation since it iterates through all the unit files on the file system. We should only run it during initial indexing (where we might need to build the initial indexstore-db) but not for any subsequent indexing calls.