Do not cache diagnostic reports for sourcekitd requests that have failed #2007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
bnbarham
approved these changes
Feb 26, 2025
| func testPullDiagnosticsAfterCrash() async throws { | ||
| try SkipUnless.longTestsEnabled() | ||
|
|
||
| // Ensure that we don't cash the diagnostic report from the crashed sourcekitd and don't emit any of the internal |
There was a problem hiding this comment.
Suggested change
| // Ensure that we don't cash the diagnostic report from the crashed sourcekitd and don't emit any of the internal | |
| // Ensure that we don't cache the diagnostic report from the crashed sourcekitd and don't emit any of the internal |
But I wouldn't restart testing for it 😅
ahoppen
force-pushed
the
dont-cache-failed-diag-reports
branch
from
2cb58d8 to
87b0a1a
Compare
|
@swift-ci Please test |
Otherwise, we return the failed diagnostic report even after sourcekitd has been restored. Also, make sure that we don't show the `semantic editor is disabled` error to users.
ahoppen
force-pushed
the
dont-cache-failed-diag-reports
branch
from
87b0a1a to
abea29c
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, we return the failed diagnostic report even after sourcekitd has been restored.
Also, make sure that we don't show the
semantic editor is disablederror to users.