Skip to content

Use response files to index files if argument list exceeds maximum number of arguments #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Mar 4, 2025

No description provided.

@ahoppen ahoppen requested review from bnbarham and hamishknight March 4, 2025 01:26
@ahoppen
Copy link
Member Author

ahoppen commented Mar 4, 2025

@swift-ci Please test

workingDirectory: workingDirectory,
outputRedirection: outputRedirection
)
} catch SystemError.posix_spawn(E2BIG, _) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't surprise me if this is different on Windows, but I imagine we'll soon see!

@ahoppen ahoppen force-pushed the ahoppen/response-file-indexing branch 2 times, most recently from f422882 to 41cce9c Compare March 4, 2025 17:14
@ahoppen
Copy link
Member Author

ahoppen commented Mar 4, 2025

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Mar 4, 2025

@swift-ci Please test Windows

@ahoppen ahoppen force-pushed the ahoppen/response-file-indexing branch 2 times, most recently from 34c3b90 to b315d43 Compare March 5, 2025 00:57
@ahoppen
Copy link
Member Author

ahoppen commented Mar 5, 2025

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Mar 5, 2025

@swift-ci Please test Windows

@ahoppen ahoppen force-pushed the ahoppen/response-file-indexing branch from b315d43 to 5541060 Compare March 5, 2025 21:33
@ahoppen
Copy link
Member Author

ahoppen commented Mar 5, 2025

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Mar 5, 2025

@swift-ci Please test Windows

@ahoppen ahoppen merged commit 9f5f06b into swiftlang:main Mar 6, 2025
3 checks passed
@ahoppen ahoppen deleted the ahoppen/response-file-indexing branch March 6, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants