Skip to content

Fix issue that caused code completion to fail using compile_flags.txt #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Mar 13, 2025

The compiler name shouldn’t be part of the build settings.

@ahoppen ahoppen requested a review from bnbarham March 13, 2025 21:21
@ahoppen
Copy link
Member Author

ahoppen commented Mar 13, 2025

@swift-ci Please test

Copy link
Contributor

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compile_flags.txt, but 👍

The compiler name shouldn’t be part of the build settings.
@ahoppen ahoppen force-pushed the hover-compile-flags branch from 2e4929a to b49b409 Compare March 14, 2025 03:19
@ahoppen ahoppen changed the title Fix issue that caused code completion to fail using compile_command.txt Fix issue that caused code completion to fail using compile_flags.txt Mar 14, 2025
@ahoppen
Copy link
Member Author

ahoppen commented Mar 14, 2025

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Mar 14, 2025

@swift-ci Please test Windows

1 similar comment
@ahoppen
Copy link
Member Author

ahoppen commented Mar 17, 2025

@swift-ci Please test Windows

@ahoppen ahoppen merged commit 20f0d3f into swiftlang:main Mar 17, 2025
3 checks passed
@ahoppen ahoppen deleted the hover-compile-flags branch March 17, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants