Wait for request to be sent to sourcekitd before cancelling it in SwiftSourceKitPluginTests.testCancellation
#2088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
…iftSourceKitPluginTests.testCancellation` Otherwise, the cancellation could get handled before the request actually gets sent to sourcekitd, which is not what we want to test here. There appears to be a second underlying issue that causes unexpected results when we cancel the fast completion request after sending the slow completion request. I’ll look at that in a follow-up PR.
ahoppen
force-pushed
the
cancellation-issue
branch
from
13cadb9 to
92f3c77
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
ahoppen
added a commit
to ahoppen/sourcekit-lsp
that referenced
this pull request
Mar 25, 2025
… and `timeoutTask` in `withTimeout` and `withTaskPriorityChangedHandler` I have not been able to reason out any concrete issues that this might fix but these are my best guesses to fix the underlying issue of swiftlang#2088
bnbarham
approved these changes
Mar 26, 2025
…n element/substring This also prints the sequence and expected element on failure, which is useful for debugging.
Undo the escaping of `\` in paths on Windows.
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
1 similar comment
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the cancellation could get handled before the request actually gets sent to sourcekitd, which is not what we want to test here. There appears to be a second underlying issue that causes unexpected results when we cancel the fast completion request after sending the slow completion request. I’ll look at that in a follow-up PR.