Rename Shutdown to ShutdownRequest #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
benlangmuir
reviewed
Jan 23, 2020
| public static let method: String = "shutdown" | ||
| public typealias Response = VoidResponse | ||
|
|
||
| public init() { } | ||
| } | ||
|
|
||
| @available(*, deprecated, message: "Use ShutdownRequest instead") |
There was a problem hiding this comment.
I think you can do @available(*, deprecated, renamed: "ShutdownRequest") and it will provide a fixit :-)
There was a problem hiding this comment.
Ah, nice improvement. Thanks!
ahoppen
force-pushed
the
shutdown-request
branch
from
ff96998 to
ce5f477
Compare
|
@swift-ci Please test |
benlangmuir
approved these changes
Jan 23, 2020
|
@swift-ci Please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have missed this type in my last renaming PR.