[NFC] Update for diagnostic changes #221
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A warning diagnostic will be emitted when discarding a function's result and the result type is Void, since that is redundant. This patch updates a test where we expect no diagnostics to be triggered.
|
This change would make us pass the test only on master swift but fail on older compilers. While we could do that if it's absolutely necessary, I prefer to maintain a larger window of compatibility. Please take a look at #222 where I've tried to avoid this issue. |
|
Oh, I originally thought about changing the test code, then I thought maybe I can just change the assertion instead. I didn’t know about the compatibility problem. Thank you for fixing it! |
|
Merged #222, which passes before and after the diagnostic change. Closing this one. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A warning diagnostic will be emitted (by swiftlang/swift#29576) when discarding a function's result and the result type is
Void, since that is redundant. This patch updates a test where we expect no diagnostics to be triggered.