[JSONRPC] Do not exit until outstanding I/O has finished #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, we care that all outstanding **writes** are finished before we call the close handler, because otherwise we may (a) send corrupted output during shutdown, or (b) drop notifications and replies sent during the shutdown process. The former is a potential issue for clients that are not robust about parse failures, and the latter is an issue for reproducibility and robustness during testing/debugging - in particular, we have some integration tests that send data without waiting for individual replies and they need to finish outstanding replies before exiting. rdar://60159448
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, we care that all outstanding writes are finished before we call the close handler, because otherwise we may (a) send corrupted output during shutdown, or (b) drop notifications and replies sent during the shutdown process. The former is an issue for clients that are not robust about parse failures, and the latter is an issue for reproducibility and robustness during testing/debugging - in particular, we have some integration tests that send data without waiting for individual replies and they need to finish outstanding replies before exiting.
rdar://60159448