Send didSave notifications to clangd if it supports it
#280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Minor update to the LSP protocol for `didSave` and `colorProvider` to be more in line with the spec - Only send color requests over to clangd if it supports it Rationale for this change: clangd recently implemented didSave support, it is used to rebuild preambles when the user edits a header file referenced by an open file. Change-Id: Ie6e2198bdeccb9d1b4083806c254475baadc2d2b
|
@swift-ci please test |
benlangmuir
reviewed
Jun 1, 2020
Sources/LanguageServerProtocol/SupportTypes/ServerCapabilities.swift
Outdated
Show resolved
Hide resolved
Change-Id: I84c4fdc9db467fb5f4375edc50969674bdcc782e
|
@swift-ci please test |
|
Friendly ping on the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
didSaveandcolorProviderto be more in line with the specRationale for this change: clangd recently implemented didSave support, it is used to rebuild preambles when the user edits a header file referenced by an open file.