[sourcekitd] Add support for having multiple notification handlers with correct sharing #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
Now that sourcekitd has its own module, clarify the naming of the subdirectories in the primary language server.
The notification handler and initialize/shutdown APIs all modify global state within the service, so handle them inside the wrapper to prevent accidental misuse. Also add support for multiplexing the notification handler, since it can be useful to have multiple handlers, especially for global notifications.
For now, we only have one concrete implementation in sourcekit-lsp itself, but it is useful for libraries to be able to wrap their own sourcekitd implementation for example if they have an existing external use of sourcekitd in C code.
Protect ourselves from ever having multiple sourcekitd instances for the same path live at once, which is not safe.
benlangmuir
force-pushed
the
sourcekitd-sharing
branch
from
7d03292 to
0670fb5
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to correctly share the (global) sourcekitd connection for a given dylib, including multiplexing of notification handlers.