build: repair build on Windows #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlangmuir
reviewed
Jun 4, 2020
| @@ -11,6 +11,10 @@ target_link_libraries(sourcekit-lsp PRIVATE | |||
| LanguageServerProtocolJSONRPC | |||
| SourceKit | |||
| TSCUtility) | |||
| if(NOT CMAKE_SYSTEM_NAME STREQUAL Darwin) | |||
| target_link_libraries(sourcekit-lsp PRIVATE | |||
| FoundationXML) | |||
There was a problem hiding this comment.
Isn't this redundant with the change to Sourcekit/CMakeLists.txt? We only use FoundationXML in that module.
There was a problem hiding this comment.
Quite possibly! This is an old change that I didn’t update. I’ll adjust and update it :)
There was a problem hiding this comment.
Ah, okay, this was needed to resolve a path issue when building against the Foundation build tree products as the import FoundationXML causes the client to see the import.
This enables building SourceKit-LSP on Windows. This is sufficient to repair the build, though it is insufficient to run currently.
benlangmuir
approved these changes
Jun 5, 2020
|
@swift-ci please test |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables building SourceKit-LSP on Windows. This is sufficient to
repair the build, though it is insufficient to run currently.