Skip to content

Fix a number of resource leaks when using SourceKit-LSP in tests or as a library #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 10, 2020

Conversation

benlangmuir
Copy link
Contributor

  • Shutdown toolchain connections on exit. This also fixes SR-11309.
  • Fix reference cycle for build system manager delegate.

Typically this would create a reference cycle.
We should solve this in the JSONRPCConnection itself, but in the
meantime workaround by keeping pipes alive until the connection has
closed.
When using SourceKit-LSP in tests (or otherwise in a library), we do not
want to leak the toolchain connections.
@benlangmuir
Copy link
Contributor Author

@swift-ci please test

@benlangmuir
Copy link
Contributor Author

@swift-ci please test macOS

1 similar comment
@benlangmuir
Copy link
Contributor Author

@swift-ci please test macOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant