Dup and redirect stdout to defend against accidental print() #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently have a regression where sourcekit-lsp stops working in some packages, because swiftpm started printing a warning to stdout. While we should also fix swiftpm, it behooves us to be more robust in sourcekit-lsp in case this happens again. Dup stdout for use by the protocol, and redirect the stdout file descriptor to stderr, which does not interfere with the protocol.
|
@swift-ci please test |
|
@swift-ci please build toolchain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have a regression where sourcekit-lsp stops working in
some packages, because swiftpm started printing a warning to stdout.
While we should also fix swiftpm, it behooves us to be more robust in
sourcekit-lsp in case this happens again. Dup stdout for use by the
protocol, and redirect the stdout file descriptor to stderr, which does
not interfere with the protocol.