Revert "Allow double dash for IndexStore-related CLI arguments" #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #306
Per swiftlang/swift-package-manager#2909 we need to roll back to swift-argument-parser 0.3.0, and the double-dash change is not compatible with that (it crashes at runtime).
I also discovered that the version of swift-argument-parser being used when building swift.org toolchains is not considering the Package.swift requirements: it is actually taking whatever version is specified in https://github.com/apple/swift/blob/db6e3af0023a3e7fdb15204ba95e3a63a53f6deb/utils/update_checkout/update-checkout-config.json#L66. Right now that happens to be 0.3.0, but it's specified manually. We will need to update that version before re-applying this change.