SKSwiftPMWorkspace: canonicalize the path prior to use #324
Conversation
Ensure that we use the file system representation for the path as otherwise the path conversion may fail. This is required for Windows which ends up with mixed path separators.
| guard let path = try? AbsolutePath(validating: url.path) else { | ||
| return nil | ||
| } | ||
| guard let path = (url.withUnsafeFileSystemRepresentation { |
There was a problem hiding this comment.
I'm surprised this is only needed in one place - why don't we have the same issue for incoming URLs from the editor?
Is there a reason you preferred withUnsafeFileSystemRepresentation instead of standardizedURL.path?
There was a problem hiding this comment.
Well, this was specifically for the test, I'm sure that I will need to do this a fair amount more as we discover the sites.
The reason for that is mostly because I did this before we had a chat, and I just failed to think about standardizedURL.path, I'll want to change to that and test it, as I think it would be better to use.
There was a problem hiding this comment.
Actually, thinking more about this, I don't think that standardizedURL.path will do what we want. That will give the path as a URI string rather than the FSR, which means that it cannot be used for the AbsolutePath(validating:) constructor.
|
I am closing this off because I believe that this is not the right approach. I think that the problem is in tools-support-core instead. I believe that swiftlang/swift-tools-support-core#140 takes care of the underlying issue making this work. |
Ensure that we use the file system representation for the path as
otherwise the path conversion may fail. This is required for Windows
which ends up with mixed path separators.