convert tests from #file to using #filePath #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlangmuir
suggested changes
Oct 7, 2020
benlangmuir
reviewed
Oct 14, 2020
|
@benlangmuir Apologies for the delay - I finally nabbed some time to circle back and finish this up, also fixing up the unintentional indenting damage I did earlier while changing things. |
benlangmuir
approved these changes
Nov 2, 2020
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally PR #307 - rebased and re-opened to align to merging into
mainbranch:I wandered in an saw a variety of warnings, this iterates through and cleans them up. I wasn't sure of dependencies for supporting older versions of swift for this project, so offering this up as cleanup work.
#fileto#filePathin the tests