Log to stderr instead of sending window/logMessage #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- clangd itself already logs to stderr so sourcekit-lsp should do the same for consistency (unless we want to capture clangd's stderr and forward it in the LSP) - Editors such as VS Code will show stderr output in the same output channel where it shows logMessage + traces Change-Id: Iaf00cffa2e64d8490e21b49a3a9d34a17f54aa9f
|
Let me know if you want me to change the time format or also include the logging level; was thinking of sending a follow up change to make requests/responses not logged by default but then log everything upon a debug log level just like clangd. |
|
@swift-ci please test |
benlangmuir
reviewed
Oct 7, 2020
| private func logImpl(_ message: String, level: LogLevel, usedOSLog: Bool) { | ||
|
|
||
| if !self.disableNSLog && !usedOSLog { | ||
| // Fallback to NSLog if os_log isn't available. | ||
| NSLog(message) | ||
| } else { | ||
| self.logToStderr(message, level: level) |
There was a problem hiding this comment.
I just checked: disableNSLog is never true except in unit tests. Should we just rely on NSLog?
There was a problem hiding this comment.
Hmm we could but won't that duplicate os_logs (os_log from us, NSLog)? If we drop our manual os_log. usage we could but it would be a slight change in behavior (filtering before logging)
There was a problem hiding this comment.
Ah sorry, I misread how it would work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clangd itself already logs to stderr so sourcekit-lsp
should do the same for consistency (unless we want to
capture clangd's stderr and forward it in the LSP)
Editors such as VS Code will show stderr output in the same
output channel where it shows logMessage + traces