Restart sourcekitd and clangd after they have crashed #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng of clangd This will later allow us to restart clangd while keeping the same shim.
|
@swift-ci Please test |
|
Thanks! It'll take me a bit to go through the whole change again since it's been a while. In the meantime, please regenerate the linux test manifests: |
benlangmuir
reviewed
Dec 3, 2020
ahoppen
force-pushed
the
crash-recovery-again
branch
from
f57eafc to
f5f26bf
Compare
|
Thanks for the thorough review @benlangmuir! Unfortunately I can't answer all of your questions in full detail, since it's just been too long since I wrote the original code. I can look into some of the questions in more detail if you think that's useful, though. @swift-ci Please test |
|
@swift-ci Please test |
ahoppen
force-pushed
the
crash-recovery-again
branch
from
f5f26bf to
8e7968b
Compare
|
@swift-ci Please test |
benlangmuir
reviewed
Jan 5, 2021
| version: snapshot.version, | ||
| text: snapshot.text) | ||
| // Re-open the document but don't register for build system notifications again since | ||
| // the document is still open in the build system server from before the sourcektid crash. |
There was a problem hiding this comment.
This comment is now out of date. Otherwise, LGTM.
There was a problem hiding this comment.
Yikes. I’ve removed the comment. Let’s get this merged. 🚀
ahoppen
force-pushed
the
crash-recovery-again
branch
from
8e7968b to
a0c9b30
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #219 to the current state of
main.Since the rebase was non-trivial and the project has changed in the meantime I would appreciate a re-review ;-)