Globally ignore SIGPIPE on Linux #382
Conversation
|
@swift-ci Please test |
|
|
||
| #if os(Linux) || os(Android) | ||
| // This is a lazily initialised global variable that when read for the first time, will ignore SIGPIPE. | ||
| private let globallyIgnoredSIGPIPE: Bool = { |
There was a problem hiding this comment.
This feels overcomplicated. Just put this as a static variable inside JSONRPCConnection and access it from the initializer. We don't need a public API for this.
There was a problem hiding this comment.
My line of thinking was that since this is a global property of the process, it should also be toggled by a global function. And I don’t think this really belongs in JSONRPCConnection either. JSONRCPConnection just requests SIGPIPE to be ignored, it shouldn’t need to worry single dispatch etc.
(also: I just copy-pased this code as-is from swift-nio)
There was a problem hiding this comment.
Let's make it an internal function at least.
There was a problem hiding this comment.
Sounds like a good compromise 👍
We receive a `SIGPIPE` if we write to a pipe that points to a crashed process. This in particular happens if the target of a `JSONRPCConnection` has crashed and we try to send it a message. On Darwin, `DispatchIO` ignores `SIGPIPE` for the pipes handled by it, but that features is not available on Linux. Instead, globally ignore `SIGPIPE` on Linux to prevent us from crashing if the `JSONRPCConnection`'s target crashes. Fixes rdar://75580936
ahoppen
force-pushed
the
pr/disable-sigpipe-linux
branch
from
09ac9f5 to
ee53f85
Compare
|
Made @swift-ci Please test |
We receive a
SIGPIPEif we write to a pipe that points to a crashed process. This in particular happens if the target of aJSONRPCConnectionhas crashed and we try to send it a message.On Darwin,
DispatchIOignoresSIGPIPEfor the pipes handled by it, but that features is not available on Linux.Instead, globally ignore
SIGPIPEon Linux to prevent us from crashing if theJSONRPCConnection's target crashes.Fixes rdar://75580936