[5.5] [swiftpm] Add derived sources to module compiler arguments #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that swiftpm has derived sources, for example the resource bundle accessor generated for `Bundle.module`, we need to ensure they get added to compiler arguments for the module as seen by sourcekit-lsp. Luckily there is now a convenient ".sources" property on the target description. https://bugs.swift.org/browse/SR-14658 (cherry picked from commit 8a65006)
|
@swift-ci please test |
akyrtzi
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that swiftpm has derived sources, for example the resource bundle
accessor generated for
Bundle.module, we need to ensure they get addedto compiler arguments for the module as seen by sourcekit-lsp. Luckily
there is now a convenient ".sources" property on the target description.
https://bugs.swift.org/browse/SR-14658
(cherry picked from commit 8a65006)