Use dynamic registration for folding range options #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dynamically register because clangd doesn't currently support it, but may in the future. Change-Id: I2bf139ea8aad09b58232ba9d09dfddcd89b977cd
|
LMK what you think, I can also swap over to use the |
|
@swift-ci please test |
|
Hmm, actually gonna see if there's an easier way - maybe VS Code will ignore our results if we instead return an error? |
|
Nope, VS Code still hides its own folding ranges when we return an error. |
benlangmuir
approved these changes
Jul 1, 2021
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamically register because clangd doesn't currently support it, but may in the future. Without this change, we don't provide any code folding in Objective-C files because our empty results override's VS Code's default implementation.