Skip to content

Add syntax highlighting to the code blocks in the markdown returned by SourceKit. #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2021
Merged

Add syntax highlighting to the code blocks in the markdown returned by SourceKit. #415

merged 3 commits into from
Jul 14, 2021

Conversation

LebJe
Copy link
Contributor

@LebJe LebJe commented Jul 14, 2021

This pull request adds syntax highlighting to the code blocks in the markdown returned by SourceKit.

Before this change, Language Server clients would either guess the language of the code block based on the opened file in the editor, or would not provide highlighting at all.

Before:

Screen Shot 2021-07-13 at 10 35 48 PM

After:

Screen Shot 2021-07-13 at 10 26 24 PM

@LebJe LebJe requested a review from benlangmuir as a code owner July 14, 2021 02:46
@ahoppen ahoppen self-assigned this Jul 14, 2021
Copy link
Contributor

@benlangmuir benlangmuir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@benlangmuir
Copy link
Contributor

@swift-ci please test

@benlangmuir
Copy link
Contributor

@swift-ci please test Linux

@benlangmuir
Copy link
Contributor

@swift-ci please test

@LebJe
Copy link
Contributor Author

LebJe commented Jul 14, 2021

Do you mind if I add another commit that formats links in documentation comments?

Before:

Before

After:

After

@benlangmuir
Copy link
Contributor

benlangmuir commented Jul 14, 2021

@LebJe please create a separate PR for that change, thanks!

@benlangmuir benlangmuir merged commit efb5adf into swiftlang:main Jul 14, 2021
@LebJe LebJe deleted the docCommentSyntaxHighlighting branch July 14, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants