Use new way when building paths based on triple. #430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
In TSC pr swiftlang#229 and SPM pr #3576, we introduced a method named `platformBuildPathComponent` to distinguish the valid platform path name versus the valid target name, where one may have an embedded version number and the other may not. SourceKit test suite SwiftPMIntegrationTests currently fails. This is presumably because this change may be required as it is one of two uses of `tripleString`. The other uses `tripleString` as the value for the `-target` field, so it is correct as written. The other -- as in this commit -- builds a path. This commit must be committed in concert with the aforementioned prs.
3405691582
force-pushed
the
PlatformBuildPathComponent
branch
from
1682c76 to
ee61890
Compare
|
Added missing |
neonichu
approved these changes
Oct 6, 2021
|
@benlangmuir, once you approve this, Boris says he will merge the three pulls. |
benlangmuir
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In TSC swiftlang/swift-tools-support-core#229 and swiftlang/swift-package-manager#3576, we introduced a method named
platformBuildPathComponentto distinguish the valid platform path nameversus the valid target name, where one may have an embedded version
number and the other may not.
SourceKit test suite SwiftPMIntegrationTests currently fails. This is
presumably because this change may be required as it is one of two
uses of
tripleString. The other usestripleStringas the value forthe
-targetfield, so it is correct as written. The other -- as inthis commit -- builds a path.
This commit must be committed in concert with the aforementioned prs.