SourceKitLSPTests: remove many cases of forced unwrapping #603
+82
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the test suite on Windows, these forced unwraps would fail. Adopt `throws` on the cases and be more lenient of the failure as that is reported as a test failure. This allows us to run the test suite to completion even if it fails.
|
@swift-ci please test |
benlangmuir
approved these changes
Aug 3, 2022
ahoppen
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the test suite on Windows, these forced unwraps would fail.
Adopt
throwson the cases and be more lenient of the failure as thatis reported as a test failure. This allows us to run the test suite to
completion even if it fails.