Pull SwiftSyntax into SourceKit-LSP #651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
requested changes
Oct 16, 2022
There was a problem hiding this comment.
Please update the CMake builds, the build-windows-toolchain.bat in apple/swift, and this will require coordination as https://GitHub.com/compnerd/swift-build will need updates to keep the official builds from breaking.
CodaFi
force-pushed
the
syn-city
branch
2 times, most recently
from
08bf040 to
259bf64
Compare
ahoppen
reviewed
Oct 18, 2022
Re-core the "lexical" token stream on top of SwiftSyntax and call into the parser to (re-)generate these "lexical tokens" when the document changes. Leave the semantic tokens alone since they take some non-zero amount of name lookup to fully resolve references to fully replicate.
|
@swift-ci test |
ahoppen
approved these changes
Oct 18, 2022
compnerd
previously requested changes
Oct 20, 2022
|
@compnerd and I worked out these issues on a separate channel. Patching Swift Syntax at swiftlang/swift-syntax#991 |
CodaFi
added a commit
to CodaFi/swift-build
that referenced
this pull request
Oct 20, 2022
As of swiftlang/sourcekit-lsp#651 sourcekit-lsp now depends on SwiftSyntax for its internal representation of documents.
compnerd
reviewed
Oct 20, 2022
compnerd
pushed a commit
to compnerd/swift-build
that referenced
this pull request
Oct 24, 2022
As of swiftlang/sourcekit-lsp#651 sourcekit-lsp now depends on SwiftSyntax for its internal representation of documents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The general idea is to try to use the syntax tree to provide an in-process source of truth about syntactic and structural document requests. Having the syntax tree in process also enables syntactic transformations and analyses that can be used to provide code actions, programmatic language features like (keyword) hovering, etc. both natively in Swift and without having to incur a hop out to SourceKit.
To that end, re-core the "lexical" token stream on top of SwiftSyntax and call into the parser to (re-)generate these "lexical tokens" when the document changes. Leave the semantic tokens alone since they take some non-zero amount of name lookup to fully resolve references to fully replicate.
A follow-on will demonstrate what we can start to do with this infrastructure.