SKCore: allow non python build servers #657
Conversation
|
Looks good to me but I’d be interested to know what your use case for this ise. |
|
@ahoppen we are using a build server to integrate language server with Buck and would like to be more flexible with languages choices, in particular we are going to write the build server in Typescript. |
|
Ah, makes sense. I somehow misread “build server” as “language server” and wondered how you wanted to use this to integrated SourceKit-LSP with another LSP server. Makes total sense now that I read it again. |
|
@swift-ci Please test |
|
CI failed with the following error Could you take a look what’s going wrong here? |
| throw BuildServerTestError.executableNotFound("python3") | ||
| } | ||
|
|
||
| serverPath = interpreterPath | ||
| } |
There was a problem hiding this comment.
Oh, I didn't realize that this was in SKCore, this makes sense. I thought that this was a test-only method, which would be fine to assume that the build server would never be an executable.
@ahoppen I missed dot in comparison of files extension and had "py" instead of ".py", I fixed it. |
|
@swift-ci Please test |
The commit 7910520 made build servers Python only. This pull requests adjusts server handling logic to use python interpreter only for the scripts with ".py" extension.