NFC: add .vscode/launch.json
#700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workspace wide configuration should be portable, and allows us to add any recommended flags, which is convenient for getting started.
|
@swift-ci test |
|
This makes sense as the launch.json is the only file automatically created by the swift extension. As an aside it would be good to remove the tasks.json it gets in the way of the build tasks internally generated by the swift extension. I've found I can't build the release build of sourcekit-lsp because build task Cmd+Shift+B defaults to the debug build. |
Ah, great catch! I didn't notice we had that one already... |
|
@swift-ci test |
|
Since I’m not a big VSCode user myself, I leave it up to @adam-fowler to decide what is good practice to commit. |
|
This PR is good. Plus maybe remove the tasks.json |
|
@swift-ci test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitted as an alternative to #699.
Per @compnerd's comment: