[swiftpm] Update to latest master #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
benlangmuir
commented
Feb 2, 2019
benlangmuir
commented
- import Utility -> import SPMUtility
- AbsolutePath.asString -> path.description or "(path)"
* import Utility -> import SPMUtility * AbsolutePath.asString -> path.description or "\(path)"
akyrtzi
approved these changes
Feb 2, 2019
aciidgh
reviewed
Feb 2, 2019
| @@ -53,10 +53,10 @@ public final class FallbackBuildSystem: BuildSystem { | |||
| if let sdkpath = sdkpath { | |||
| args += [ | |||
| "-sdk", | |||
| sdkpath.asString, | |||
| sdkpath.description, | |||
There was a problem hiding this comment.
description is for producing human readable path, please use pathString where you want to guarantee proper string representation.
There was a problem hiding this comment.
Thanks, will do. I was wondering about this when I did it, and I chose description because that's what the SwiftPM change did. I didn't realize that pathString didn't exist at the time of that change. It all makes more sense now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.