[swiftpm] Statically link to libSwiftPM #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to using the swiftpm library with automatic linkage, which in practice means we will statically link to libSwiftPM using the standard build. This change allows us to install the sourcekit-lsp binary without also installing a copy of libSwiftPM.dylib (and since swiftpm isn't using a stable ABI we couldn't share that with anything). Previously this was blocked by conflicts between the llvm code in llbuild and in indexstore-db, but this has been resolved.
akyrtzi
approved these changes
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to using the swiftpm library with automatic linkage, which in practice means we will statically link to libSwiftPM using the standard build. This change allows us to install the sourcekit-lsp binary without also installing a copy of libSwiftPM.dylib (and since swiftpm isn't using a stable ABI we couldn't share that with anything). Previously this was blocked by conflicts between the llvm code in llbuild and in indexstore-db, but this has been resolved.