[test] Make swiftpm test robust against host triple differences #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hardcoding the triples was silly; the only interesting platform difference is about which parts have a version number on macOS and which do not.
akyrtzi
approved these changes
Mar 1, 2019
| @@ -111,11 +112,11 @@ final class SwiftPMWorkspaceTests: XCTestCase { | |||
|
|
|||
| check("-target", arguments: arguments) // Only one! | |||
| #if os(macOS) | |||
| check("-target", "x86_64-apple-macosx10.10", arguments: arguments) | |||
| check("-target", Triple.hostTriple.tripleString(forPlatformVersion: "10.10"), arguments: arguments) | |||
There was a problem hiding this comment.
I wonder if due to this issue: https://twitter.com/jckarter/status/1095757933579689985 we shouldn't stick to minimum 10.11 on macOS?
There was a problem hiding this comment.
If this ever breaks we can change it, but this test won't try to generate code, so I think it's probably fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hardcoding the triples was silly; the only interesting platform
difference is about which parts have a version number on macOS and which
do not.