Skip to content

Workaround perf test running too many iterations #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Workaround perf test running too many iterations #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions Tests/SKSupportTests/SupportPerfTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ final class SupportPerfTests: PerfTestCase {
"\t", "\n"
] + (32...126).map { Character(UnicodeScalar($0)) }

// The debug performance is shockingly bad.
#if DEBUG
#if DEBUG || !ENABLE_PERF_TESTS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please not run any perf tests on the PR bots?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already not running as a performance test (i.e. I hooked the measure family of methods so that they don't check perf and only run their block once).

let iterations = 1_000
#else
let iterations = 10_000
Expand Down Expand Up @@ -54,8 +53,7 @@ final class SupportPerfTests: PerfTestCase {
"\t", "\n"
] + (32...126).map { Character(UnicodeScalar($0)) }

// The debug performance is shockingly bad.
#if DEBUG
#if DEBUG || !ENABLE_PERF_TESTS
let iterations = 1_000
let size = 1_000
#else
Expand Down